From 41d651a84c7391cf996756c287a747e328e8b936 Mon Sep 17 00:00:00 2001 From: MikeHughes-BIN Date: Sat, 17 Jan 2026 14:16:57 +0100 Subject: [PATCH] Refactor document creation logic to improve readability and maintainability by rearranging variable declarations in chatgpt, gemini, and qwen3 modules. --- services/modules/llm-chat_gpt/chatgpt.js | 8 ++++---- services/modules/llm-gemini/gemini.js | 8 ++++---- services/modules/quen3/qwen3.js | 8 ++++---- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/services/modules/llm-chat_gpt/chatgpt.js b/services/modules/llm-chat_gpt/chatgpt.js index 24c47d7..877307b 100644 --- a/services/modules/llm-chat_gpt/chatgpt.js +++ b/services/modules/llm-chat_gpt/chatgpt.js @@ -42,10 +42,6 @@ const module_exports = { createDocumentFromTranscript: async function(transcriptPath, documentTypePath, language = "en") { // default language is English return new Promise(async(resolve, reject) => { try { - const transcript = await fs.promises.readFile(transcriptPath, "utf-8"); //read transcript file from Path - const documentType = await fs.promises.readFile(documentTypePath, "utf-8"); //read document type from Path - const promptText = `${documentType}, in language ${language}, transcript:\n\n${transcript}`; //combine doc type, language and transcript - Change prompt here if needed - if (language.toLowerCase() === "de") { language = "German" }else if (language.toLowerCase() === "in") { @@ -53,6 +49,10 @@ const module_exports = { } else { language = "English" } + + const transcript = await fs.promises.readFile(transcriptPath, "utf-8"); //read transcript file from Path + const documentType = await fs.promises.readFile(documentTypePath, "utf-8"); //read document type from Path + const promptText = `${documentType}, in language ${language}, transcript:\n\n${transcript}`; //combine doc type, language and transcript - Change prompt here if needed // return // --- REST CALL --- diff --git a/services/modules/llm-gemini/gemini.js b/services/modules/llm-gemini/gemini.js index 8fd012c..ec486c0 100644 --- a/services/modules/llm-gemini/gemini.js +++ b/services/modules/llm-gemini/gemini.js @@ -40,10 +40,6 @@ const module_exports = { createDocumentFromTranscript: async function(transcriptPath, documentTypePath, language = "en") { // default language is English return new Promise(async(resolve, reject) => { try { - const transcript = await fs.promises.readFile(transcriptPath, "utf-8"); //read transcript file from Path - const documentType = await fs.promises.readFile(documentTypePath, "utf-8"); //read document type from Path - const promptText = `${documentType}, in language ${language}, transcript:\n\n${transcript}`; //combine doc type, language and transcript - Change prompt here if needed - if (language.toLowerCase() === "de") { language = "German" }else if (language.toLowerCase() === "in") { @@ -52,6 +48,10 @@ const module_exports = { language = "English" } + const transcript = await fs.promises.readFile(transcriptPath, "utf-8"); //read transcript file from Path + const documentType = await fs.promises.readFile(documentTypePath, "utf-8"); //read document type from Path + const promptText = `${documentType}, in language ${language}, transcript:\n\n${transcript}`; //combine doc type, language and transcript - Change prompt here if needed + // --- REST CALL --- const response = await fetch(`${GEMINI_URL}?key=${GEMINI_API_KEY}`, { //safe model response in variable method: "POST", diff --git a/services/modules/quen3/qwen3.js b/services/modules/quen3/qwen3.js index d6c03cd..84e8f7b 100644 --- a/services/modules/quen3/qwen3.js +++ b/services/modules/quen3/qwen3.js @@ -40,10 +40,6 @@ const module_exports = { createDocumentFromTranscript: async function(transcriptPath, documentTypePath, language = "en") { // default language is English return new Promise(async(resolve, reject) => { try { - const transcript = await fs.promises.readFile(transcriptPath, "utf-8"); //read transcript file from Path - const documentType = await fs.promises.readFile(documentTypePath, "utf-8"); //read document type from Path - const promptText = `${documentType}, in language ${language}, transcript:\n\n${transcript}`; //combine doc type, language and transcript - Change prompt here if needed - if (language.toLowerCase() === "de") { language = "German" }else if (language.toLowerCase() === "in") { @@ -51,6 +47,10 @@ const module_exports = { } else { language = "English" } + + const transcript = await fs.promises.readFile(transcriptPath, "utf-8"); //read transcript file from Path + const documentType = await fs.promises.readFile(documentTypePath, "utf-8"); //read document type from Path + const promptText = `${documentType}, in language ${language}, transcript:\n\n${transcript}`; //combine doc type, language and transcript - Change prompt here if needed // --- REST CALL --- const response = await fetch(SAIA_URL, { //safe model response in variable